Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VPC] Support NSXLB for VPC #618

Merged
merged 1 commit into from
Jul 30, 2024
Merged

[VPC] Support NSXLB for VPC #618

merged 1 commit into from
Jul 30, 2024

Conversation

gran-vmv
Copy link
Contributor

@gran-vmv gran-vmv commented Jun 27, 2024 •
edited
Loading

When NSXLB is enabled, create NSX LBS with VPC and skip AviLB code, and store NSX LBS path to VPCNetworkConfuguration status.

@gran-vmv gran-vmv self-assigned this Jun 27, 2024
@gran-vmv gran-vmv force-pushed the lbvpc-1 branch 3 times, most recently from 5040cc2 to 4c564f5 Compare July 3, 2024 05:59
@gran-vmv gran-vmv requested review from heypnus and TaoZou1 July 4, 2024 03:00
@gran-vmv gran-vmv force-pushed the lbvpc-1 branch 8 times, most recently from 660f1a2 to 9d8f41b Compare July 8, 2024 03:55
@gran-vmv
Copy link
Contributor Author

gran-vmv commented Jul 8, 2024 •
edited
Loading

Verified with latest NSXT. However, the realization time is too long to DefaultRetry.

status:
{
    "consolidated_status": {
        "consolidated_status": "SUCCESS"
    },
    "consolidated_status_per_enforcement_point": [
        {
            "resource_type": "ConsolidatedStatusPerEnforcementPoint",
            "enforcement_point_id": "default",
            "consolidated_status": {
                "consolidated_status": "SUCCESS"
            }
        }
    ],
    "publish_status": "REALIZED",
    "intent_version": "0",
    "intent_path": "/orgs/default/projects/project-quality/vpcs/418f860d-a2fc-4dcb-bc77-c59eedf045b4/vpc-lbs/418f860d-a2fc-4dcb-bc77-c59eedf045b4"
}

realized-entities:
{
    "results": [
        {
            "extended_attributes": [
                {
                    "data_type": "STRING",
                    "multivalue": false,
                    "key": "service_error_message"
                },
                {
                    "data_type": "STRING",
                    "multivalue": false,
                    "values": [
                        "42eb6532-3a87-11ef-9f38-000c29c18e29"
                    ],
                    "key": "standby_transport_nodes"
                },
                {
                    "data_type": "STRING",
                    "multivalue": false,
                    "values": [
                        "1720421390701"
                    ],
                    "key": "last_update_timestamp"
                },
                {
                    "data_type": "STRING",
                    "multivalue": false,
                    "values": [
                        "UP"
                    ],
                    "key": "service_status"
                },
                {
                    "data_type": "STRING",
                    "multivalue": false,
                    "key": "memory_usage"
                },
                {
                    "data_type": "STRING",
                    "multivalue": false,
                    "values": [
                        "94c2a942-3a87-11ef-9343-000c29b21f97"
                    ],
                    "key": "active_transport_nodes"
                },
                {
                    "data_type": "STRING",
                    "multivalue": false,
                    "key": "cpu_usage"
                }
            ],
            "entity_type": "LbServiceDto",
            "intent_paths": [
                "/orgs/default/projects/project-quality/vpcs/418f860d-a2fc-4dcb-bc77-c59eedf045b4/vpc-lbs/418f860d-a2fc-4dcb-bc77-c59eedf045b4"
            ],
            "resource_type": "GenericPolicyRealizedResource",
            "id": "418f860d-a2fc-4dcb-bc77-c59eedf045b4",
            "display_name": "418f860d-a2fc-4dcb-bc77-c59eedf045b4",
            "path": "/orgs/default/projects/project-quality/vpcs/418f860d-a2fc-4dcb-bc77-c59eedf045b4/realized-state/enforcement-points/default/lb-services/418f860d-a2fc-4dcb-bc77-c59eedf045b4",
            "relative_path": "418f860d-a2fc-4dcb-bc77-c59eedf045b4",
            "parent_path": "/orgs/default/projects/project-quality/vpcs/418f860d-a2fc-4dcb-bc77-c59eedf045b4/realized-state/enforcement-points/default",
            "unique_id": "bf04c0b7-3837-4c86-8ccb-98e5a69dd3cd",
            "realization_id": "bf04c0b7-3837-4c86-8ccb-98e5a69dd3cd",
            "owner_id": "204df74a-5006-462b-8f34-7ee58a4eeb22",
            "intent_reference": [
                "/orgs/default/projects/project-quality/vpcs/418f860d-a2fc-4dcb-bc77-c59eedf045b4/vpc-lbs/418f860d-a2fc-4dcb-bc77-c59eedf045b4"
            ],
            "realization_specific_identifier": "ee84d8d3-ecab-44c3-9dac-6db636de465c",
            "realization_api": "/api/v1/loadbalancer/services/ee84d8d3-ecab-44c3-9dac-6db636de465c",
            "state": "REALIZED",
            "alarms": [
            ],
            "runtime_status": "UP",
            "publish_status": "UNINITIALIZED",
            "_system_owned": false,
            "_protection": "NOT_PROTECTED",
            "_create_time": 1720421181082,
            "_create_user": "system",
            "_last_modified_time": 1720421400132,
            "_last_modified_user": "system",
            "_revision": 2
        }
    ],
    "result_count": 1
}

@gran-vmv gran-vmv force-pushed the lbvpc-1 branch 2 times, most recently from 4712571 to 59bcda2 Compare July 8, 2024 07:39
@gran-vmv gran-vmv force-pushed the lbvpc-1 branch 5 times, most recently from 1f37f48 to 4a1d178 Compare July 9, 2024 08:15
@gran-vmv gran-vmv force-pushed the lbvpc-1 branch 2 times, most recently from 9e220fe to 957c765 Compare July 19, 2024 02:42
@gran-vmv gran-vmv changed the title [VPC] Support NSXLB for VPC [VPC] Support NSXLB for VPC +1 Jul 19, 2024
@gran-vmv gran-vmv force-pushed the lbvpc-1 branch 3 times, most recently from 9b5f59e to 9ea1373 Compare July 23, 2024 02:38
@gran-vmv gran-vmv changed the title [VPC] Support NSXLB for VPC +1 [VPC] Support NSXLB for VPC Jul 23, 2024
@gran-vmv gran-vmv force-pushed the lbvpc-1 branch 2 times, most recently from 6a1b83d to 9d29b36 Compare July 25, 2024 08:25
@gran-vmv
Copy link
Contributor Author

/e2e

dantingl
dantingl reviewed Jul 29, 2024
View reviewed changes
Copy link
Contributor

@dantingl dantingl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to create github issues for the TODOs in your patch

pkg/nsx/services/vpc/builder.go Outdated Show resolved Hide resolved
pkg/nsx/services/vpc/builder.go Outdated Show resolved Hide resolved
pkg/nsx/services/vpc/vpc.go Outdated Show resolved Hide resolved
zhengxiexie
zhengxiexie reviewed Jul 29, 2024
View reviewed changes
pkg/nsx/services/common/wrap.go Show resolved Hide resolved
pkg/nsx/services/realizestate/realize_state.go Outdated Show resolved Hide resolved
pkg/nsx/services/vpc/wrap.go Show resolved Hide resolved
@gran-vmv
[VPC] Support NSXLB for VPC
dec48b2 
Signed-off-by: gran <gran@vmware.com>
@gran-vmv
Copy link
Contributor Author

/e2e

@gran-vmv gran-vmv merged commit 0784c07 into vmware-tanzu:main Jul 30, 2024
2 checks passed
@gran-vmv gran-vmv mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantingl dantingl dantingl approved these changes

@zhengxiexie zhengxiexie zhengxiexie approved these changes

@lxiaopei lxiaopei Awaiting requested review from lxiaopei

@heypnus heypnus Awaiting requested review from heypnus

@yuntanghsu yuntanghsu Awaiting requested review from yuntanghsu

@TaoZou1 TaoZou1 Awaiting requested review from TaoZou1

Assignees

@gran-vmv gran-vmv

Labels
action/backport cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gran-vmv @zhengxiexie @dantingl @yuntanghsu @TaoZou1 @vmwclabot